viljarb/LazyPM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

remove setup issues and simplify validaiton

Browse Source
This commit is contained in:
Robin Olsen
2026-03-19 15:21:30 +01:00
parent 64a02a6ed5
commit b0c76b0565
10 changed files with 91 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
cmd/pm/tasks/issueReviewCleanup.go
View File

@@ -12,12 +12,12 @@ const issueReviewCleanupDescription = `You are responsible for reviewing and mai
Using the system, complete the following steps:
1. Add a comment to two issues
2. Delete this cleanup task issue ("Issue Review and Cleanup Task") from the issue list — do not delete the other project issues`
2. Delete the issue titled "Delete this issue"`
type IssueReviewCleanupTask struct {
done bool
app *App
setupIssue *models.Issue
done bool
app *App
reviewIssues []*models.Issue
}
func NewIssueReviewCleanupTask(app *App) *IssueReviewCleanupTask {
@@ -49,10 +49,10 @@ func (t *IssueReviewCleanupTask) Setup(ctx context.Context) error {
return err
}
reviewIssues := []*models.Issue{
t.reviewIssues = []*models.Issue{
models.NewIssueBuilder().
WithTitle("Fix login page layout").
WithDescription("The login form is misaligned on smaller screens. Needs responsive CSS adjustments.").
WithTitle("Delete this issue").
WithDescription("").
WithPriority(2).
WithStatus(models.StatusOpen).
WithIssueType(models.TypeTask).
@@ -87,22 +87,13 @@ func (t *IssueReviewCleanupTask) Setup(ctx context.Context) error {
Build(),
}
if err := t.app.Issues.CreateIssues(ctx, reviewIssues, ""); err != nil {
return err
}
t.setupIssue = models.NewBaseIssue().
WithTitle("Issue Review and Cleanup Task").
WithDescription(issueReviewCleanupDescription).
Build()
return t.app.Issues.CreateIssue(ctx, t.setupIssue, "")
return t.app.Issues.CreateIssues(ctx, t.reviewIssues, "")
}
func (t *IssueReviewCleanupTask) Validate(ctx context.Context) ValidationFeedback {
expect := check.NewExpector()
issues, err := FetchIssues(ctx, t.app, t.setupIssue)
issues, err := FetchIssues(ctx, t.app)
if err != nil {
return expect.Fatal("Could not fetch issues")
}
@@ -123,16 +114,18 @@ func (t *IssueReviewCleanupTask) Validate(ctx context.Context) ValidationFeedbac
}
expect.Equal(commentsInIssues, 2, "Comments on issues")
expect.Equal(len(issues), len(t.reviewIssues)-1, "Remaining issues after cleanup")
// Fetching the setup issue as as FetchIssues only updates the setup issue if it exists,
// we can check if it was deleted by seeing if it can be fetched again
if t.setupIssue, err = t.app.Issues.GetIssue(ctx, t.setupIssue.ID); t.setupIssue != nil {
expect.Fail("Setup issue still exists")
} else {
expect.Pass("Setup issue deleted")
issue, err := t.app.Issues.GetIssue(ctx, t.reviewIssues[0].ID)
if err != nil {
return expect.Fatal("Deleted issue should not be found")
}
expect.Equal(len(issues), 5, "Number of remaining issues")
if issue != nil {
expect.Fail("The issue titled 'Delete this issue' should have been deleted.")
} else {
expect.Pass("Issue deleted successfully")
}
return expect.Complete()
}